Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend to vite #3860
frontend to vite #3860
Changes from 65 commits
0da1348
9742e5a
e07d7a5
ed12f3f
5b5fee4
e996bf9
b55d5e7
ea5bdff
f9f15e2
f535509
2e91e11
5272a41
ca0e36e
97a7d42
2b6c671
c7c221f
e1474e7
2aa7b2e
b28d452
279632f
1db2e9a
9f2b7ae
c712cf3
0439c3c
55821e6
8bc8dce
5e4dde4
670f384
cc1bff8
3643bbd
40e5c35
5a69005
d645a42
2269487
3456407
e9ecfc2
552db39
7c2243a
b2fe04e
fd90fbc
ae90f22
a0423db
dcbaefe
8e59196
2acb3f6
6b714ab
efa7fc9
99702cc
11282f9
0077b0d
e4d42c1
c61ad52
596df6a
9b0012a
144475c
6526fd4
40d2b23
098c0a9
a7109f1
53e1234
935d196
4e056cf
9f88471
0ef2d80
1299818
4f6ed2c
d6addac
d2a106f
b8561de
ed46971
a7e258d
c96b92c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a personal preference. I'm always going in node modules. But other people want it hidden?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine. Where it can kind of get annoying is if you're doing a global string search in the repo and node modules are indexed those results can cloud what you're looking for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean when you're searching using vscode? on my end at least if this button is clicked then it will ignore node_modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah in vscode, interesting ok, will check that button out.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.