Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASA Radio Buttons #3861

Merged
merged 3 commits into from
Aug 19, 2024
Merged

ASA Radio Buttons #3861

merged 3 commits into from
Aug 19, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Aug 19, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.74%. Comparing base (e51872c) to head (7631611).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3861   +/-   ##
=======================================
  Coverage   79.74%   79.74%           
=======================================
  Files         295      295           
  Lines       10888    10888           
  Branches      518      518           
=======================================
  Hits         8683     8683           
  Misses       2061     2061           
  Partials      144      144

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw requested a review from conbrad August 19, 2024 19:10
conbrad
conbrad approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@brettedw brettedw temporarily deployed to production August 19, 2024 21:07 Inactive
@brettedw brettedw merged commit 4a2667d into main Aug 19, 2024
28 checks passed
@brettedw brettedw deleted the task/asa-radio-buttons branch August 19, 2024 21:15
conbrad pushed a commit that referenced this pull request Aug 19, 2024
@brettedw @conbrad
ASA Radio Buttons (#3861)
cf50337 
Changes actual/forecast dropdown to radio buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conbrad conbrad conbrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ASA: Convert the Forecast OR Actual Dropdown to a Radio Button Group
2 participants
@brettedw @conbrad