Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASA - About This Data #3890

Merged
merged 10 commits into from
Sep 3, 2024
Merged

ASA - About This Data #3890

merged 10 commits into from
Sep 3, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Sep 3, 2024 •
edited
Loading

  • Adds 'About This Data' button to ASA which currently just displays information about the advisory thresholds and a but about fuel types for future work
  • Closes ASA: Disclaimer - About this data #3854

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.73%. Comparing base (41b98f8) to head (24ed37a).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3890   +/-   ##
=======================================
  Coverage   79.73%   79.73%           
=======================================
  Files         295      295           
  Lines       10891    10891           
  Branches      519      519           
=======================================
  Hits         8684     8684           
  Misses       2063     2063           
  Partials      144      144

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw requested review from conbrad and dgboss September 3, 2024 21:35
dgboss
dgboss approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just a couple minor comments.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@brettedw brettedw temporarily deployed to production September 3, 2024 23:11 Inactive
@brettedw brettedw merged commit f3780aa into main Sep 3, 2024
28 checks passed
@brettedw brettedw deleted the task/asa-about branch September 3, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgboss dgboss dgboss approved these changes

@conbrad conbrad conbrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ASA: Disclaimer - About this data
3 participants
@brettedw @conbrad @dgboss