Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None handling in TPI endpoint #3912

Merged
merged 3 commits into from
Sep 11, 2024
Merged

None handling in TPI endpoint #3912

merged 3 commits into from
Sep 11, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Sep 10, 2024

Returns None for TPI stats and adds handling on the frontend
Closes #3911

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@conbrad conbrad requested review from brettedw and dgboss September 10, 2024 23:19
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (601d2a2) to head (ecb012b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3912      +/-   ##
==========================================
+ Coverage   81.27%   81.31%   +0.04%     
==========================================
  Files         294      294              
  Lines       11362    11362              
  Branches      526      526              
==========================================
+ Hits         9234     9239       +5     
+ Misses       2094     2089       -5     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 11, 2024

@conbrad conbrad temporarily deployed to production September 11, 2024 16:08 Inactive
@conbrad conbrad merged commit fac4b2f into main Sep 11, 2024
28 checks passed
@conbrad conbrad deleted the task/fix-tpi-none-bg branch September 11, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'pixel_size_metres'
3 participants