Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial bug fixes #3921

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Trivial bug fixes #3921

merged 1 commit into from
Sep 12, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Sep 12, 2024

  • Fix date display logic
  • Show message when fire centre selected but no fire zone unit HFI data available (eg. Select date in the future)
  • Hide 'No critical hours available' text when no warning or advisory has been issued.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@dgboss dgboss requested review from conbrad and brettedw September 12, 2024 17:17
Copy link

sonarcloud bot commented Sep 12, 2024

Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (5493240) to head (33e3d9c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3921   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         294      294           
  Lines       11362    11362           
  Branches      526      526           
=======================================
  Hits         9239     9239           
  Misses       2089     2089           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss temporarily deployed to production September 12, 2024 17:35 Inactive
@dgboss dgboss merged commit 6cfbdac into main Sep 12, 2024
28 checks passed
@dgboss dgboss deleted the bug/asa-no-data-text branch September 12, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants