Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store incomplete rows in drafts #3960

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Store incomplete rows in drafts #3960

merged 3 commits into from
Sep 24, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Sep 24, 2024

This PR makes sure that all edited rows get stored, not just edited rows with simulated FWIs.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (8b16372) to head (f70c3e9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/features/moreCast2/components/TabbedDataGrid.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3960      +/-   ##
==========================================
- Coverage   81.35%   81.34%   -0.02%     
==========================================
  Files         298      298              
  Lines       11421    11423       +2     
  Branches      541      541              
==========================================
  Hits         9292     9292              
- Misses       2094     2096       +2     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss requested review from brettedw and conbrad September 24, 2024 17:38
Copy link

sonarcloud bot commented Sep 24, 2024

@dgboss dgboss temporarily deployed to production September 24, 2024 22:49 Inactive
@dgboss dgboss merged commit 817518c into main Sep 24, 2024
25 checks passed
@dgboss dgboss deleted the bug/morecast-draft branch September 24, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants