Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSU Insights #4147

Merged
merged 17 commits into from
Dec 4, 2024
Merged

PSU Insights #4147

merged 17 commits into from
Dec 4, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Dec 2, 2024

  • closes SFMS: Create New UI #4124
  • Adds new PSU Insights page
    • Contains simple map with 2km fuel grid pmtiles
  • Adds Tool Card for the new page (only in dev for now)
  • Link to new page is in the Test Links below

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
PSU Insights

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.34%. Comparing base (8235d3c) to head (1cca940).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/psuInsights/components/map/psuFeatureStylers.ts 70.00% 3 Missing ⚠️
web/src/features/landingPage/toolInfo.tsx 0.00% 2 Missing ⚠️
...src/features/psuInsights/components/map/PSUMap.tsx 88.88% 0 Missing and 2 partials ⚠️
...src/features/psuInsights/pages/PSUInsightsPage.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4147      +/-   ##
==========================================
- Coverage   80.78%   80.34%   -0.44%     
==========================================
  Files         310      313       +3     
  Lines       11896    11941      +45     
  Branches      537      540       +3     
==========================================
- Hits         9610     9594      -16     
+ Misses       2168     2159       -9     
- Partials      118      188      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw closed this Dec 2, 2024
@brettedw brettedw reopened this Dec 2, 2024
@brettedw brettedw closed this Dec 2, 2024
@brettedw brettedw reopened this Dec 2, 2024
@brettedw brettedw requested review from dgboss and conbrad December 3, 2024 20:09
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! It looks great!
Just the one question about transparency/opacity.

Copy link

sonarcloud bot commented Dec 4, 2024

@brettedw brettedw temporarily deployed to production December 4, 2024 18:31 Inactive
@brettedw brettedw merged commit 0ee473d into main Dec 4, 2024
26 checks passed
@brettedw brettedw deleted the task/psu-insights branch December 4, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SFMS: Create New UI
3 participants