From 7cceeb3b9a73e845807755ff414d84b7e71e2aa4 Mon Sep 17 00:00:00 2001 From: Joe Pegler Date: Mon, 26 Aug 2024 12:13:55 +0100 Subject: [PATCH] chore: tidy --- .github/workflows/playground.yml | 2 -- package.json | 2 +- src/account/NexusSmartAccount.ts | 11 ++++------- src/account/utils/Types.ts | 3 --- tests/README.md | 6 ++++++ 5 files changed, 11 insertions(+), 13 deletions(-) diff --git a/.github/workflows/playground.yml b/.github/workflows/playground.yml index dd3e1845..58987fb7 100644 --- a/.github/workflows/playground.yml +++ b/.github/workflows/playground.yml @@ -1,8 +1,6 @@ name: playground on: workflow_dispatch: - pull_request: - types: [opened, reopened, synchronize, ready_for_review] jobs: playground: name: playground diff --git a/package.json b/package.json index 02f69c9c..8fbda4a2 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "sideEffects": false, "name": "@biconomy/sdk", "author": "Biconomy", - "version": "0.1.0", + "version": "0.0.1", "description": "SDK for Biconomy integration with support for account abstraction, smart accounts, ERC-4337.", "keywords": [ "erc-7579", diff --git a/src/account/NexusSmartAccount.ts b/src/account/NexusSmartAccount.ts index 0e5461f8..a2a75b5e 100644 --- a/src/account/NexusSmartAccount.ts +++ b/src/account/NexusSmartAccount.ts @@ -1421,14 +1421,11 @@ export class NexusSmartAccount extends BaseSmartContractAccount { userOp.signature = dummySignature - if (!buildUseropDto?.skipBundler) { - const gasFeeValues: GetUserOperationGasPriceReturnType | undefined = - await this.bundler?.getGasFeeValues() + const gasFeeValues: GetUserOperationGasPriceReturnType | undefined = + await this.bundler?.getGasFeeValues() - userOp.maxFeePerGas = gasFeeValues?.fast.maxFeePerGas ?? 0n - userOp.maxPriorityFeePerGas = - gasFeeValues?.fast.maxPriorityFeePerGas ?? 0n - } + userOp.maxFeePerGas = gasFeeValues?.fast.maxFeePerGas ?? 0n + userOp.maxPriorityFeePerGas = gasFeeValues?.fast.maxPriorityFeePerGas ?? 0n userOp = await this.estimateUserOpGas(userOp) diff --git a/src/account/utils/Types.ts b/src/account/utils/Types.ts index c5b6fe05..725eb7ec 100644 --- a/src/account/utils/Types.ts +++ b/src/account/utils/Types.ts @@ -209,7 +209,6 @@ export type BuildUserOpOptions = { dummyPndOverride?: BytesLike useEmptyDeployCallData?: boolean useExecutor?: boolean - skipBundler?: boolean } export type NonceOptions = { @@ -285,8 +284,6 @@ export type InitializeV2Data = { export type EstimateUserOpGasParams = { userOp: Partial - /** Currrently has no effect */ - // skipBundlerGasEstimation?: boolean; /** paymasterServiceData: Options specific to transactions that involve a paymaster */ paymasterServiceData?: SponsorUserOperationDto } diff --git a/tests/README.md b/tests/README.md index 542bdcf8..fe080f39 100644 --- a/tests/README.md +++ b/tests/README.md @@ -2,6 +2,9 @@ ## Testing Setup +> **Note**: +> - Tests now must be run with node version >= v22 + ### Network Agnostic Tests - Tests are executed against locally deployed ephemeral Anvil chains (chain ID: 31337) with relevant contracts pre-deployed for each test. - Bundlers for testing are instantiated using [prool](https://github.com/wevm/prool), currently utilizing alto instances. We plan to switch to Biconomy's bundlers when they become available via `prool`. @@ -56,3 +59,6 @@ scopedTest("should be used in the following way", async({ config: { bundlerUrl, ## Debugging and Client Issues It is recommended to use the playground for debugging issues with clients. Please refer to the following guidelines for escalation and handover: [Debugging Client Issues](https://www.notion.so/biconomy/Debugging-Client-Issues-cc01c1cab0224c87b37a4d283370165b) +## Testing Helpers +A [testClient](https://viem.sh/docs/clients/test#extending-with-public--wallet-actions) Was made available (funded and extended with walletActions and publicActions) during testing. Please use it as a master Client for all things network related. +