Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the nested sampler integration. The API now allows more direct communication between the user and the sampler by passing keyword arguments directly to the sampler function calls. Prospector now looks at the signatures of function calls in the different sampler packages and dynamically assigns the appropriate keyword arguments passed by the user. At the same time, the following keyword arguments remain "global", i.e., prospector translates them into the corresponding keyword arguments for the respective sampler.
nested_neff
: The minimum effective sample size.nested_nlive
: The number of live points.verbose
: Whether to give progress updates.I also ended up removing the keyword arguments
nested_bound
,nested_sample
,nested_walks
, andnested_dlogz
. My reason was that it was somewhat confusing that they had slightly different names than in dynesty. Plus, they don't always have a corresponding parameter in the other samplers. The main practical advantage of the new implementation is that prospector doesn't needs to follow changing APIs in the samplers. For example, if a sampler implements a new keyword argument, users can directly utilize it without having to update prospector. Finally, whether parallelization with MPI works as expected for every sampler may still need to be checked.