Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working with empty Spectrum object #359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wangbingjie
Copy link
Contributor

First attempt to allow for an empty object in obs. I am just creating this PR in case it would be helpful when we are ready to solve this problem properly; i.e., we don't necessarily need to merge this (especially given that I am not entirely sure I know what I am doing with p-v2...). Note that this version does not solve all the errors; specifically, this error remains when writing to an h5 file in observation.py, in to_struct:

if (len(dat) != self.ndata):
TypeError: len() of unsized object

But I am less familiar with the io part....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant