From 1ec5dd9d28061e22091bb4aaf2338b8ff85ea627 Mon Sep 17 00:00:00 2001 From: David Little Date: Mon, 15 Apr 2024 09:23:16 -0400 Subject: [PATCH 1/4] give credit to original authors --- LICENSE.md | 16 ++++------------ README.md | 7 +++++++ 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/LICENSE.md b/LICENSE.md index f8b1e2a..85862f5 100644 --- a/LICENSE.md +++ b/LICENSE.md @@ -1,6 +1,9 @@ MIT License -Copyright (c) 2021 Beacon Biosignals +Copyright (c) 2016-2023 The Julia Team +Copyright (c) 2018-2023 Mauro Werder +Copyright (c) 2023 Max Horn +Copyright (c) 2024 Beacon Biosignals Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal @@ -19,14 +22,3 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. - -The source implementation was originally copied from that found in `AbstractAlgebra.jl` -located here: https://github.com/Nemocas/AbstractAlgebra.jl, and is available under the following 2-clause BSD license: - -> Copyright (c) 2014-2016: William Hart, Tommy Hofmann, Claus Fieker, Fredrik Johansson. - -> Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: - -> Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. -> Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. -> THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. diff --git a/README.md b/README.md index ddf8966..71c739e 100644 --- a/README.md +++ b/README.md @@ -22,3 +22,10 @@ GC.gc(true) ``` Avoid assuming a key exists in a `WeakKeyIdDict`, especially when allocation occurs. Keys can be removed any time garbage collection occurs. Favor the methods `get!` and `get` over `getindex`. + + +## Credits + +Much of the credit for the implementation of WeakKeyIdDict goes to Maura Werder (@mauro3) for the initial [work in the julia repository](https://github.com/JuliaLang/julia/pull/28182), and [DataStructures](https://github.com/JuliaCollections/DataStructures.jl/pull/402). Max Horn (@fingolfin) then updated and debugged a version merged to [AlbstractAlgebra](https://github.com/Nemocas/AbstractAlgebra.jl/pull/1419). + +The version here adds a few additional tests for edge-cases, fixing related bugs along the way, that arose from work in base [julia](https://github.com/JuliaLang/julia). From 9df5ca15df838702b99f1a49c48f5291a16c4fa0 Mon Sep 17 00:00:00 2001 From: David Little Date: Mon, 15 Apr 2024 09:28:37 -0400 Subject: [PATCH 2/4] Update README.md Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 71c739e..0d33c15 100644 --- a/README.md +++ b/README.md @@ -28,4 +28,4 @@ Avoid assuming a key exists in a `WeakKeyIdDict`, especially when allocation occ Much of the credit for the implementation of WeakKeyIdDict goes to Maura Werder (@mauro3) for the initial [work in the julia repository](https://github.com/JuliaLang/julia/pull/28182), and [DataStructures](https://github.com/JuliaCollections/DataStructures.jl/pull/402). Max Horn (@fingolfin) then updated and debugged a version merged to [AlbstractAlgebra](https://github.com/Nemocas/AbstractAlgebra.jl/pull/1419). -The version here adds a few additional tests for edge-cases, fixing related bugs along the way, that arose from work in base [julia](https://github.com/JuliaLang/julia). +The version here adds a few additional tests for edge-cases, fixing related bugs along the way, using code from some of the `IdDict` tests from Base [julia](https://github.com/JuliaLang/julia). From 649be0bdee0f4bfd795c319bb1a7eaeb64d456f6 Mon Sep 17 00:00:00 2001 From: David Little Date: Mon, 15 Apr 2024 10:05:18 -0400 Subject: [PATCH 3/4] Update README.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Lars Göttgens --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0d33c15..6fa3366 100644 --- a/README.md +++ b/README.md @@ -26,6 +26,6 @@ Avoid assuming a key exists in a `WeakKeyIdDict`, especially when allocation occ ## Credits -Much of the credit for the implementation of WeakKeyIdDict goes to Maura Werder (@mauro3) for the initial [work in the julia repository](https://github.com/JuliaLang/julia/pull/28182), and [DataStructures](https://github.com/JuliaCollections/DataStructures.jl/pull/402). Max Horn (@fingolfin) then updated and debugged a version merged to [AlbstractAlgebra](https://github.com/Nemocas/AbstractAlgebra.jl/pull/1419). +Much of the credit for the implementation of WeakKeyIdDict goes to Mauro Werder (@mauro3) for the initial [work in the julia repository](https://github.com/JuliaLang/julia/pull/28182), and [DataStructures](https://github.com/JuliaCollections/DataStructures.jl/pull/402). Max Horn (@fingolfin) then updated and debugged a version merged to [AlbstractAlgebra](https://github.com/Nemocas/AbstractAlgebra.jl/pull/1419). The version here adds a few additional tests for edge-cases, fixing related bugs along the way, using code from some of the `IdDict` tests from Base [julia](https://github.com/JuliaLang/julia). From fdbbbbfe81082da11e32ce0c8209b665b03f43fc Mon Sep 17 00:00:00 2001 From: David Little Date: Mon, 15 Apr 2024 10:06:37 -0400 Subject: [PATCH 4/4] spelling --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6fa3366..ff7d575 100644 --- a/README.md +++ b/README.md @@ -26,6 +26,6 @@ Avoid assuming a key exists in a `WeakKeyIdDict`, especially when allocation occ ## Credits -Much of the credit for the implementation of WeakKeyIdDict goes to Mauro Werder (@mauro3) for the initial [work in the julia repository](https://github.com/JuliaLang/julia/pull/28182), and [DataStructures](https://github.com/JuliaCollections/DataStructures.jl/pull/402). Max Horn (@fingolfin) then updated and debugged a version merged to [AlbstractAlgebra](https://github.com/Nemocas/AbstractAlgebra.jl/pull/1419). +Much of the credit for the implementation of WeakKeyIdDict goes to Mauro Werder (@mauro3) for the initial [work in the julia repository](https://github.com/JuliaLang/julia/pull/28182), and [DataStructures](https://github.com/JuliaCollections/DataStructures.jl/pull/402). Max Horn (@fingolfin) then updated and debugged a version merged to [AbstractAlgebra](https://github.com/Nemocas/AbstractAlgebra.jl/pull/1419). The version here adds a few additional tests for edge-cases, fixing related bugs along the way, using code from some of the `IdDict` tests from Base [julia](https://github.com/JuliaLang/julia).