Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to exclude column by name or data type from escape_formulas #128

Open
jsonbecker opened this issue Mar 21, 2024 · 0 comments
Open

Comments

@jsonbecker
Copy link

If this is a feature request, why do we need it?

  • escape_formulas indiscriminately adds ' to all fields with the @escape_formula_start values of ["=", "-", "+", "@"] which is great and follows the OWASP guidance, except...
  • Negative numbers are real and this causes huge problems with round-tripping negative numbers.
  • There is no risk posed by data that has a - in front that is stored in Elixir as any numeric type-- the risk is data destruction in cases where non-numeric data starts with a -.

Open questions

  • Can we skip based on type before coercing to string or is it better to ask for columns to skip?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant