From b2c43d2b8e8e930b3204333fedbc25527c7bc43e Mon Sep 17 00:00:00 2001 From: Russell Keith-Magee Date: Thu, 31 Dec 2020 13:44:14 +0800 Subject: [PATCH 1/2] Updated workflow syntax. --- .github/workflows/publish.yaml | 6 +++--- .github/workflows/release.yaml | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index 685b2ec..fd2c962 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -23,9 +23,9 @@ jobs: export TAG_BUILD="${TAG#*-}" echo "PY_VERSION=${TAG_VERSION}" echo "BUILD_NUMBER=${TAG_BUILD}" - echo "::set-env name=TAG::${TAG}" - echo "::set-env name=PY_VERSION::${TAG_VERSION}" - echo "::set-env name=BUILD_NUMBER::${TAG_BUILD}" + echo "TAG=${TAG}" >> $GITHUB_ENV + echo "PY_VERSION=${TAG_VERSION}" >> $GITHUB_ENV + echo "BUILD_NUMBER=${TAG_BUILD}" >> $GITHUB_ENV - name: Update Release Asset to S3 env: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index ea19a6a..8777a78 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -21,9 +21,9 @@ jobs: export TAG_BUILD="${TAG#*-}" echo "PY_VERSION=${TAG_VERSION}" echo "BUILD_NUMBER=${TAG_BUILD}" - echo "::set-env name=TAG::${TAG}" - echo "::set-env name=PY_VERSION::${TAG_VERSION}" - echo "::set-env name=BUILD_NUMBER::${TAG_BUILD}" + echo "TAG=${TAG}" >> $GITHUB_ENV + echo "PY_VERSION=${TAG_VERSION}" >> $GITHUB_ENV + echo "BUILD_NUMBER=${TAG_BUILD}" >> $GITHUB_ENV - name: Create Release id: create_release uses: actions/create-release@v1 @@ -62,9 +62,9 @@ jobs: export TAG_BUILD="${TAG#*-}" echo "PY_VERSION=${TAG_VERSION}" echo "BUILD_NUMBER=${TAG_BUILD}" - echo "::set-env name=TAG::${TAG}" - echo "::set-env name=PY_VERSION::${TAG_VERSION}" - echo "::set-env name=BUILD_NUMBER::${TAG_BUILD}" + echo "TAG=${TAG}" >> $GITHUB_ENV + echo "PY_VERSION=${TAG_VERSION}" >> $GITHUB_ENV + echo "BUILD_NUMBER=${TAG_BUILD}" >> $GITHUB_ENV - name: Build ${{ matrix.target }} env: BUILD_NUMBER: ${{ env.BUILD_NUMBER }} From 95f4251dc68ac25ccaa238adf7aae5d1a31fc28b Mon Sep 17 00:00:00 2001 From: Russell Keith-Magee Date: Sat, 2 Jan 2021 10:48:45 +0800 Subject: [PATCH 2/2] Remove use of homebrew's version of curl. --- .github/workflows/release.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 8777a78..71a78e2 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -83,7 +83,10 @@ jobs: # 2020-06-24: The Homebrew copy of gettext leaks into the macOS build # if it is present. Uninstall gettext to make sure that doesn't happen. - brew uninstall --ignore-dependencies gettext + # 2021-01-02: Uninstall curl as well. We need curl to download the + # source bundles, but Homebrew's curl has a runtime dependency on + # gettext. However macOS provides a version of curl that works fine. + brew uninstall --ignore-dependencies gettext curl # Do the build for the requested target. make -e ${{ matrix.target }}