Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all Briefcase tables in pyproject.toml during conversion #1899

Open
rmartin16 opened this issue Jul 7, 2024 · 1 comment
Open

Include all Briefcase tables in pyproject.toml during conversion #1899

rmartin16 opened this issue Jul 7, 2024 · 1 comment
Labels
enhancement New features, or improvements to existing features. good first issue Is this your first time contributing? This could be a good place to start!

Comments

@rmartin16
Copy link
Member

What is the problem or limitation you are having?

When an existing project is converted to use Briefcase, only the [tool.briefcase] and [tool.briefcase.app.<app name>] tables are populated. This makes it more difficult to take advantage of Briefcase's packaging controls because all of the those pyproject.toml tables must be created manually.

Describe the solution you'd like

Populate pyproject.toml with the platform-specific tables when converting an existing project. At the least, I see benefit from creating the empty tables; however, there are likely at least some keys that are worth exposing for all projects.

Describe alternatives you've considered

Manually create all platform tables in pyproject.toml.

Additional context

No response

@rmartin16 rmartin16 added the enhancement New features, or improvements to existing features. label Jul 7, 2024
@freakboy3742
Copy link
Member

The thinking around omitting the tables was that we wouldn't be able to infer any default values, as we don't know the list of dependencies for an arbitrary app; but I agree that at least empty tables with placeholders for common requires, system_requires etc configurations would make sense.

@freakboy3742 freakboy3742 added the good first issue Is this your first time contributing? This could be a good place to start! label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features, or improvements to existing features. good first issue Is this your first time contributing? This could be a good place to start!
Projects
None yet
Development

No branches or pull requests

2 participants