From 2f329901a28e5077fcd0172ba317e2e670a58fd0 Mon Sep 17 00:00:00 2001 From: Russell Martin Date: Fri, 7 Jun 2024 20:24:05 -0400 Subject: [PATCH] Remove leftover TODOs --- core/src/toga/sources/list_source.py | 1 - core/src/toga/widgets/detailedlist.py | 1 - core/src/toga/widgets/mapview.py | 1 - core/src/toga/window.py | 1 - 4 files changed, 4 deletions(-) diff --git a/core/src/toga/sources/list_source.py b/core/src/toga/sources/list_source.py index f64aeaa7d7..666bc71925 100644 --- a/core/src/toga/sources/list_source.py +++ b/core/src/toga/sources/list_source.py @@ -96,7 +96,6 @@ def __delattr__(self, attr: str) -> None: self._source.notify("change", item=self) -# TODO:PR: consider adding supported Protocols...maybe List? class ListSource(Source): _data: list[Row] diff --git a/core/src/toga/widgets/detailedlist.py b/core/src/toga/widgets/detailedlist.py index 676f0e1361..a5ec7937e0 100644 --- a/core/src/toga/widgets/detailedlist.py +++ b/core/src/toga/widgets/detailedlist.py @@ -110,7 +110,6 @@ def __init__( self._secondary_action = secondary_action self.on_select = None - # TODO:PR: in reality, _data needs to be Sized and SupportsIndex... self._data: SourceT | ListSource = None self._impl = self.factory.DetailedList(interface=self) diff --git a/core/src/toga/widgets/mapview.py b/core/src/toga/widgets/mapview.py index 0ba7b8ab40..dd69651b07 100644 --- a/core/src/toga/widgets/mapview.py +++ b/core/src/toga/widgets/mapview.py @@ -75,7 +75,6 @@ def subtitle(self, subtitle: str | None) -> None: self.interface._impl.update_pin(self) -# TODO:PR: __contains__() is required to subclass Set; should it not be added? class MapPinSet: def __init__(self, interface: MapView, pins: Iterable[MapPin] | None): self.interface = interface diff --git a/core/src/toga/window.py b/core/src/toga/window.py index f4fafb5cea..725e5c4a9e 100644 --- a/core/src/toga/window.py +++ b/core/src/toga/window.py @@ -105,7 +105,6 @@ class Dialog(AsyncResult): RESULT_TYPE = "dialog" def __init__(self, window: Window, on_result: DialogResultHandler[Any]): - # TODO:PR: should DialogResultHandlerT include the "exception" arg... super().__init__(on_result=on_result) self.window = window self.app = window.app