-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version inconsistency? python 3.8 vs 3.9? #2797
Comments
Thanks for the report, and apologies for the confusion around this. Right now, Toga needs to be tested on Python 3.8; but that doesn't mean pre-commit needs to be run on Python 3.8. It looks like one of the recent releases of pre-commit has dropped Python 3.8 support; as a result, the pre-commit checks can't currently be run in a Python 3.8 environment So - at least for the moment, the virtual environment where you perform your commits (or run pre-commit) needs to be Python 3.9 or later. However, you can use this Python3.9 environment to run That said - Toga's support for Python 3.8 support in Toga is not long for this world - we'll be dropping it before the end of October when 3.8 hits EOL. I'll leave this ticket open as a guide for others; the "fix" is to finalise the deprecation of Python 3.8 in Toga. |
Ah that's too bad, I wasn't aware it was hitting EOL so soon. FWIW I believe Python 3.8 is the last python version supported on windows 7. |
That's a bit of a moot point from Toga's perspective, as Windows 7 is also EOL, and Toga doesn't support it. |
Describe the bug
pre-commit is failing with the following error:
however toga documentation clearly states it should support 3.8?
https://github.com/beeware/toga#minimum-requirements
Expected behavior
pre-commit runs successfully, without complaining about my python version
Environment
master
Logs
Additional context
Putting all this information together I'm understanding that Toga contributors are required to have python 3.9, however if I'm testing and working around python 3.8 limitations, am I expected to test in 3.8, and then test again in 3.9, running pre-commit, before contributing a solution??
The text was updated successfully, but these errors were encountered: