.cs code files in Shared Projects are not formatted

[samtrion]

If you use Shared Projects .shproj, the contents are not formatted here. Although the code actually belongs to the consuming .csproj projects.

[belav]

Do you have an example of your setup? I am assuming the projects are using CSharpier.MSBuild. The dotnet tool just works on directory contents and has been working with the CSharpier VS plugin, which uses a shared project.

[samtrion]

https://github.com/dailydevops/healthchecks/tree/feature%2Fsqlserver

[belav]

Can you provide more than just a link? How do I reproduce the problem?

[samtrion]

I have created a sample repository with the error image. - https://github.com/samtrion/bug-csharpier-945

By way of explanation, I use a Directory.Packages.props file in parallel with the .sln file to manage packages. Through this file I inject CSharpier into all projects.

The code inside the .csproj projects is formatted correctly, but the code inside the .shproj or .projitems is not formatted. There is a standard import between the projects.

The same error pattern can be observed via a link reference to a file.

<ItemGroup>
  <Compile Include="..\Test.Shared\ExtraLongMethodBody.cs" Link="ExtraLongMethodBody.cs" />
</ItemGroup>

Also in this case the file ExtraLongMethodBody.cs is not formatted.

[belav]

Thanks, I can see the problem now, but there isn't an easy fix.

The way CSharpier.MSBuild currently works is by just running dotnet csharpier against the project directory. It doesn't currently understand anything about the project. It also will not format a file if it was included from outside of the project directory and will format files that were excluded from the project.

dotnet format does this to determine formattable files - https://github.com/dotnet/format/blob/452f6263277533da0af2b557003256d98fbecc27/src/CodeFormatter.cs#L171

There may be some other way to do this in the context of msbuild, but my googling hasn't turned up anything yet.