Fixing regression issue with weird breaking of linq statement. #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belav
force-pushed
the
invocation-regression
branch
from
63b97dc to
6260db7
Compare
alanssitis
pushed a commit
to alanssitis/csharpier
that referenced
this pull request
Jan 22, 2024
…#1133) * Adding test case and tracking the code that caused the problem closes belav#1130 * Fixing regression with invocations * Fixing some edge cases * One last edge case * format file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1130
As part of this work I ended up cleaning a number of related edge cases. Examples can be seen in https://github.com/belav/csharpier-repos/pull/100/files
There may be some cases it made a bit worse, but I think the changes are a step forward.