-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for c# 12 collection expressions #966
Conversation
It looks like I need to add code to ensure that syntax tree validation accounts for collection expressions. With the new csharpier-repos
|
@@ -11,7 +11,7 @@ jobs: | |||
- uses: actions/setup-dotnet@v1 | |||
with: | |||
dotnet-version: | | |||
7.0.304 | |||
7.0.400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On an unrelated note, I think you can the whole "default variables" feature to share this constant between all the different yaml files you have, so you only have to update it once in future:
https://docs.github.com/en/actions/learn-github-actions/variables#defining-configuration-variables-for-multiple-workflows
@@ -2,7 +2,7 @@ FROM mcr.microsoft.com/dotnet/aspnet:7.0 AS base | |||
WORKDIR /app | |||
EXPOSE 80 | |||
|
|||
FROM mcr.microsoft.com/dotnet/sdk:7.0.304 AS build | |||
FROM mcr.microsoft.com/dotnet/sdk:7.0.400 AS build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the whole variables thing I said in the other comment works out, you can make this an ARG
and pass it from the yaml.
I'm going to merge this anyway, since the comments I made weren't directly related to this PR. |
closes #964