Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule identifiers + description should be a static pair / or modify violation parsing to accomodate for different descriptions #51

Open
smals-mavh opened this issue Jan 9, 2025 · 0 comments
Assignees

Comments

@smals-mavh
Copy link
Collaborator

In violation parsing, violations can be grouped by rule.
The description used is the one from the first violation that is parsed. The message can be different for every violation.

Currently some rules put different descriptions for the same violation identifier (possibly resulting in wrongly parsed violations in the output)

Probably best to have an enum with the identifier and description for each rule, and use that in the violation creation. And update the rules to use the message property in the violation object to differentiate different kind of violations within the same rule.

@smals-mavh smals-mavh self-assigned this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant