-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforcing monthly/weekly budget? #5
Comments
Right now there are two limits. The per-gift limit ( I don't see a good reason not to add a global per-day limit. I think the default should either be 0 (no limit) or some number of dollars per employee; you could look at (Also, I went ahead and gave you a commit bit and added you to the NPM project. Use them wisely. 😄) |
I love the idea of letting the team organically figure out what kind of bonus amounts fit what kind of situation. But to get this funded by the higher-ups, I'll need to provide some reassurance that costs won't run amok.
I understand that there's a
HUBOT_HIGHFIVE_DAILY_LIMIT
which controls how much any single user can give out in a day. However, it seems this wouldn't exactly help to control a monthly budget.What I'm looking for is a way to add another condition, to make sure that a gross monthly (or even better, weekly) budget is not exceeded before approving a highfive.
Just wanted to check if there was any reason not to do this, or if it was possible already in some way.
If not, and the answer is "PRs Welcome!" I'll happily get right to it!
The text was updated successfully, but these errors were encountered: