Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong unsigned readers for int16_t and int32_t #15

Open
sfrieske opened this issue Oct 22, 2023 · 0 comments
Open

wrong unsigned readers for int16_t and int32_t #15

sfrieske opened this issue Oct 22, 2023 · 0 comments

Comments

@sfrieske
Copy link

In getReaders the unsigned int readers are used:
int16_t: offset => dv.getUint16(offset, true),
int32_t: offset => dv.getUint32(offset, true),

This prevents detection of return values of -1 as errors. Must be a typo :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sfrieske