Add "Discard Cleaner" page to dashboard UI #1538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR closes this issue #1464
Here is the final version of the page:
This is to help people manage the discarded jobs and take action on specific failed jobs or specific exceptions.
At the moment, no modifications to the database have been made, but I believe it would be interesting in the future to have the
error_class
anderror_message
in separate columns in theGoodJob::Job
table. This way we could add indexes to make some filters more performant and even add a new select to thediscarded
table to filter byerror_class
(just like we have for queue and job).PS: I opened a discussion question about the i18n case, at this moment I added the keys to the other languages with the same value as the English one, let me know what's the best way to handle this.
Thanks!