fix(evict): Switch to LRU to prevent removed transactions from being re-gossiped from a peer instantly.

[itsdevbear]

Summary by CodeRabbit

• Refactor
  • Improved transaction handling efficiency in the network.
• Performance Improvements
  • Enhanced cache management for better performance.

[coderabbitai]

Warning

Rate Limit Exceeded

@itsdevbear has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 21 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between e98d8b8 and 7a0f5e9.

Walkthrough

The recent updates to the Cosmos runtime's transaction pool involve optimizations and refactoring, particularly in handling transactions and telemetry metrics. The logic for dropping remote transactions has been shifted to a more appropriate function, enhancing code organization and efficiency. Additionally, the transition to a more scalable cache mechanism in the comet component significantly increases its capacity, indicating a move towards handling higher volumes of data more efficiently.

Changes

Files	Change Summaries
.../txpool/ante.go, .../txpool/mempool.go	Moved dropping of remote transactions to Remove method; updated telemetry counter for ejected txs.
.../txpool/comet.go	Switched to lru.Cache for cometRemoteCache, increased defaultCacheSize.

🐇✨
In the cosmos wide and vast,
Changes swift, not one to last.
From maps to caches, sleek and fast,
A hop, a leap, in tech amassed.
🚀🌌

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 863ecb0 and e98d8b8.

Files selected for processing (3)

• cosmos/runtime/txpool/ante.go (1 hunks)
• cosmos/runtime/txpool/comet.go (2 hunks)
• cosmos/runtime/txpool/mempool.go (1 hunks)

Additional comments: 7

cosmos/runtime/txpool/comet.go (7)

• 27-27: The import of the lru package from github.com/ethereum/go-ethereum/common/lru is correctly added to support the LRU caching mechanism.
• 31-31: The increase of defaultCacheSize from 4096 to 100000 significantly enlarges the cache capacity. Ensure that this change is aligned with memory management and performance objectives, considering the potential impact on resource usage.
• 44-44: Switching timeInserted to use lru.Cache instead of a map is a key change. This aligns with the objective to adopt an LRU caching strategy. Ensure the type parameters [common.Hash, int64] correctly represent the transaction hash and its insertion time.
• 50-50: The instantiation of timeInserted with lru.NewCache[common.Hash, int64](defaultCacheSize) correctly applies the increased cache size. This change is crucial for implementing the LRU caching strategy effectively.
• 55-55: The IsRemoteTx method's implementation using crc.timeInserted.Contains(txHash) correctly checks for the presence of a transaction hash in the cache, leveraging the LRU cache's capabilities.
• 60-60: In MarkRemoteSeen, adding the transaction hash and the current Unix timestamp to the cache with crc.timeInserted.Add(txHash, time.Now().Unix()) is appropriate for tracking when a transaction was first seen.
• 64-65: The TimeFirstSeen method correctly retrieves the insertion time of a transaction hash from the cache. The omission of error handling after crc.timeInserted.Get(txHash) is acceptable given the method's return type and usage context.