cmake/xplatform builds using github/tox/conda workflows #187

sarnold · 2022-10-10T19:15:09Z

add example workflows for CI and local development
enable cmake options for IPO, LLVM source coverage, really simple test
handles visibility a bit differently; see size of shared lib/executables with lto/ipo and namespace
builds on cmake PR Add 'pure' cmake build system #26 (includes commits and python update script)
demonstrates several toolchains/build methods across GH ci runners
includes some warning cleanup and edge-case build errors

Majority of changed files are new cmake files so it's fairly easy to see the actual source changes. I started this back when the cmake PR was fairly new, and then I got busy (so fresh rebase on current master).

From ubuntu-clang workflow:

-rwxr-xr-x 1 runner docker  16K Oct 10 19:23 ../staging/bin/abc
-rw-r--r-- 1 runner docker 5.0K Oct 10 19:15 ../staging/include/abc/abcapis.h
-rw-r--r-- 1 runner docker 3.4K Oct 10 19:15 ../staging/include/abc/abcapis_old.h
-rw-r--r-- 1 runner docker  826 Oct 10 19:16 ../staging/lib/cmake/abc/abcConfig-release.cmake
-rw-r--r-- 1 runner docker 4.8K Oct 10 19:16 ../staging/lib/cmake/abc/abcConfig.cmake
-rw-r--r-- 1 runner docker  13M Oct 10 19:23 ../staging/lib/libabc.so.1.1.0

sarnold · 2022-10-10T19:20:06Z

CMakeLists.txt

-    set(make_env ${CMAKE_COMMAND} -E env SDKROOT=${CMAKE_OSX_SYSROOT})
-endif()
-
-# run make to extract compiler options, linker options and list of source files


I'm not sure I understand the requirement driving this; can you elaborate a little bit here?

Sorry, that ^^ question was in regards to cmake docs, where it says:

"... It is intended to be set locally by the user creating a build tree. "

https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_SYSROOT.html

sarnold · 2023-07-23T04:02:43Z

Fresh rebase-on-the-rebase with some cleanup and timespec fix.

fix a handful of warnings, add missing gia.c to module.make add makefile overrides and a soname, make library symlinks add separate shared library/test targets add -fvisibility=hidden to cxxflags, makes build result much smaller add visibility pragma for demo consumer add ci workflow with simple gcc/clang matrix Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>

* update cmake source modules using PR script * add basic versioning for cmake shared libs * complete target/install properties, export config * move toolchain file to tools dir, add python script from PR * add tox file, update ci workflow to use it * tox handles most build tool dependencies, cmake, ninja, cpplint * make sure ABC_USE_STDINT_H is fallback if ABC_USE_NAMESPACE is not set Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>

* fix type invalid literal errors * use pSat2 from abcglucuse2 header for correct cec solver type Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>

* add win32 defines ABC_NO_DYNAMIC_LINKING, WIN32 * static_cast => uint returns in acbTest.c !refactor * check for win first, win/mingw definitions inside if(msys or mingw) * fix missing leading ddunder on mingw32__ * switch msys env for clang64, re-enable readline * cleanup cmake type checks and workflow env * mingw clang-64 thinks sizeof long is 4 * use abc typedefs instead of hard-coded types Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>

The assert is disabled in release builds.

* define HAVE_STRUCT_TIMESPEC and _XKEYCHECK_H on msvc * avoid LIBSTDCXX linking (msvc only), pass build config to all steps * add optional lto support; note clang lto requires llvm-config and lld * add llvm source-based coverage build, fix uninitialzed variable * update cmake-posix workflow configure, bin path, emulate in tox * add conda devenv file and workflow => use platform compilers and Ninja * update build instructions in readme file, cleanup tox/ci files Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>

* remove the linker optimization arg for gnu on macos * remove GH workflow warning annotations, bump action versions Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

* updates tox argument syntax on macos * also restores missing OS list in conda-dev workflow Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>

* win pthreads module tries to define timespec if HAVE_STRUCT_TIMESPEC is not defined except msys/mingw already defines it Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

* use more specific if check for windows includes * add missing win32 link library * move extern Io_MvLoadFileBz2 to header, use hdr in cmd.c Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

* msys/mingw has incomplete dirent so disable namespace * refactor cmake config, update dirent pkg spec in conda env * try cheap ENV hack to find dirent header in conda Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

* update setup-miniconda config to get latest pkg versions * add more workflow output, reset cache number * list envs, revert to previous with some info output, back to v2 Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

* leave default PY_VER but do not specify version for action * use proper activate command workflow in build step * add some path and prefix introspection, try find/which * bump windows ci runner version, list env, cat dirent.h * do not use jinja compier templates, revert to py39/win2019 default Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

* cleanup initial extern hacks and use ioAbc.h for missing symbol * remove superfluous dirent dep on windows Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

sarnold commented Oct 10, 2022

View reviewed changes

sarnold changed the title ~~Github and tox workflows~~ cmake/xplatform builds using github/tox/conda workflows Oct 19, 2022

sarnold force-pushed the workflows branch from a461b36 to 93d1c2b Compare October 29, 2022 23:32

sarnold mentioned this pull request Nov 1, 2022

Disabling usage of readline header when only C++ API to avoid depending on libreadline-dev package #174

Open

sarnold force-pushed the workflows branch 7 times, most recently from 91dae88 to 9a268ee Compare July 23, 2023 03:38

sarnold force-pushed the workflows branch 4 times, most recently from ba547b1 to d63c541 Compare July 23, 2023 19:27

sarnold force-pushed the workflows branch 14 times, most recently from a029c8b to 2d82a9d Compare December 2, 2023 04:08

sarnold force-pushed the workflows branch 11 times, most recently from 5b1d8fb to 088ae33 Compare December 10, 2023 03:34

sarnold and others added 18 commits December 9, 2023 19:36

Add pure cmake build system

7e7b0a5

Export Abc_RealMain if building shared libabc

d333f43

fix: make clang build work, mainly C++ type/literal errors

8c7df74

* fix type invalid literal errors * use pSat2 from abcglucuse2 header for correct cec solver type Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>

Silence warning about unused variables

ab18ccf

The assert is disabled in release builds.

fix: dev: run manual cmake commands from build dir on macos

0e160e3

* remove the linker optimization arg for gnu on macos * remove GH workflow warning annotations, bump action versions Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

post-rebase generate/update CMakeLists.txt files, update tox file

c44b3ca

* updates tox argument syntax on macos * also restores missing OS list in conda-dev workflow Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>

fix timespec redefinition errors on windows

b163a57

* win pthreads module tries to define timespec if HAVE_STRUCT_TIMESPEC is not defined except msys/mingw already defines it Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

chg: dev: add (new) generated cmake sources

7c2de69

Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

chg: dev: update python versions, add CPUS env var to tox file

2fd6664

Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

fix: dev: address toolchain requirement changes

4cf7692

* use more specific if check for windows includes * add missing win32 link library * move extern Io_MvLoadFileBz2 to header, use hdr in cmd.c Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

fix: dev: cleanup desktop and ci workflows

146b57c

* msys/mingw has incomplete dirent so disable namespace * refactor cmake config, update dirent pkg spec in conda env * try cheap ENV hack to find dirent header in conda Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

fix: dev: relax ifdef check in cmd.c and make it windows-specific

5569a67

* cleanup initial extern hacks and use ioAbc.h for missing symbol * remove superfluous dirent dep on windows Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

sarnold force-pushed the workflows branch from 088ae33 to 5569a67 Compare December 10, 2023 03:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmake/xplatform builds using github/tox/conda workflows #187

cmake/xplatform builds using github/tox/conda workflows #187

sarnold commented Oct 10, 2022 •

edited

Loading

sarnold Oct 10, 2022 •

edited

Loading

sarnold Dec 1, 2023

sarnold commented Jul 23, 2023 •

edited

Loading

cmake/xplatform builds using github/tox/conda workflows #187

Are you sure you want to change the base?

cmake/xplatform builds using github/tox/conda workflows #187

Conversation

sarnold commented Oct 10, 2022 • edited Loading

sarnold Oct 10, 2022 • edited Loading

Choose a reason for hiding this comment

sarnold Dec 1, 2023

Choose a reason for hiding this comment

sarnold commented Jul 23, 2023 • edited Loading

sarnold commented Oct 10, 2022 •

edited

Loading

sarnold Oct 10, 2022 •

edited

Loading

sarnold commented Jul 23, 2023 •

edited

Loading