From 93e8dc4c48ba24294d52ee7254c26aa2ec24f526 Mon Sep 17 00:00:00 2001 From: Mark Haslinghuis Date: Sat, 9 Sep 2023 22:34:00 +0200 Subject: [PATCH] Simplify motor idle config --- locales/en/messages.json | 7 ++----- src/js/tabs/motors.js | 3 +-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/locales/en/messages.json b/locales/en/messages.json index 0e70dfe512f..e693d414484 100755 --- a/locales/en/messages.json +++ b/locales/en/messages.json @@ -1349,11 +1349,8 @@ "configurationDigitalIdlePercent": { "message": "Motor Idle ( %, static)" }, - "configurationDigitalIdlePercentDisabled": { - "message": "Dynamic Idle is active at {{dynamicIdle}} rpm. See the PID tuning tab." - }, "configurationDigitalIdlePercentHelp": { - "message": "The 'Motor Idle (static)' value is the percent of maximum throttle that is sent to the ESCs when the throttle at minimum stick position and the craft is armed.

Increase it to gain more idle speed and avoid desyncs. Too high and the craft feels floaty. Too low and the motors can desync or be slow to start up.

In 4.3, when Dynamic Idle is active, the static idle value is disregarded, because the idle value is continually adjusted to maintain the configured minimum rpm on the slowest motor." + "message": "The 'Motor Idle (static)' value is the percent of maximum throttle that is sent to the ESCs when the throttle at minimum stick position and the craft is armed.

Increase it to gain more idle speed and avoid desyncs. Too high and the craft feels floaty. Too low and the motors can desync or be slow to start up." }, "configurationMotorPoles": { "message": "Motor poles", @@ -4535,7 +4532,7 @@ "message": "Dynamic Idle Value [* 100 RPM]" }, "pidTuningIdleMinRpmHelp": { - "message": "Dynamic Idle improves control at low rpm and reduces risk of motor desyncs.

It improves PID authority, zero throttle stability, inverted hang time, and motor braking.

The Dynamic Idle min rpm should be set to around 3000 - 3500 rpm. For 4.2, set the DShot idle value low, eg 1%. There is no need to adjust the DShot Idle value in 4.3.

Visit this wiki entry for more info." + "message": "Dynamic Idle improves control at low rpm and reduces risk of motor desyncs.

It improves PID authority, zero throttle stability, inverted hang time, and motor braking.

The Dynamic Idle min rpm should be set to around 3000 - 3500 rpm.

Visit this wiki entry for more info." }, "pidTuningIdleMinRpmDisabled": { "message": "Dynamic Idle is OFF because Dshot Telemetry is OFF" diff --git a/src/js/tabs/motors.js b/src/js/tabs/motors.js index 71a46352ccb..3a8e01d8ae6 100644 --- a/src/js/tabs/motors.js +++ b/src/js/tabs/motors.js @@ -777,8 +777,7 @@ motors.initialize = async function (callback) { } if (FC.ADVANCED_TUNING.idleMinRpm && FC.MOTOR_CONFIG.use_dshot_telemetry) { - const dynamicIdle = FC.ADVANCED_TUNING.idleMinRpm * 100; - $('span.digitalIdlePercentDisabled').text(i18n.getMessage('configurationDigitalIdlePercentDisabled', { dynamicIdle })); + $('div.digitalIdlePercent').hide(); } else { $('span.digitalIdlePercentDisabled').text(i18n.getMessage('configurationDigitalIdlePercent')); }