Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra / causes the S3 bucket to have an empty "folder" at the beginning #33

Open
ibiris opened this issue Mar 6, 2020 · 1 comment
Open

Extra / causes the S3 bucket to have an empty "folder" at the beginning #33

ibiris opened this issue Mar 6, 2020 · 1 comment

Comments

@ibiris
Copy link

ibiris commented Mar 6, 2020

jsonschema2db/jsonschema2db.py

Line 365 in 60832f5

s3_path = '/%s/%s/%s.csv' % (self._s3_prefix, batch_random, table)

If every key string in S3 should start with a / then the path where this key is appended should not have a / otherwise you will end up with paths like

s3://bucketname//prefix/...
@erikbern
Copy link
Contributor

erikbern commented Mar 6, 2020

feel free to submit a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikbern @ibiris