From fa0cb5908830865af481cfa670f530c5082f74d1 Mon Sep 17 00:00:00 2001
From: Ivan Malopinsky <imsky@users.noreply.github.com>
Date: Wed, 17 Apr 2019 17:39:28 -0400
Subject: [PATCH] add namespace filtering

---
 LICENSE      |  2 +-
 main.go      | 22 ++++++++++++++++++++--
 main_test.go | 19 +++++++++++++++++++
 3 files changed, 40 insertions(+), 3 deletions(-)

diff --git a/LICENSE b/LICENSE
index f266579..51a7970 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2018 Better Mortgage
+Copyright (c) 2018-2019 Better Mortgage
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git a/main.go b/main.go
index 85c16ce..8879968 100644
--- a/main.go
+++ b/main.go
@@ -131,16 +131,34 @@ func filterObjectsByLabel(objects []runtime.Object, label string) []runtime.Obje
 	return filteredObjects
 }
 
+func filterObjectsByNamespace(objects []runtime.Object, namespace string) []runtime.Object {
+	if namespace == "" {
+		return objects
+	}
+
+	filteredObjects := make([]runtime.Object, 0, 1)
+	for _, o := range objects {
+		metadata, _ := getObjectMetadata(o)
+		if metadata.GetNamespace() == namespace {
+			filteredObjects = append(filteredObjects, o)
+		}
+	}
+
+	return filteredObjects
+}
+
 func main() {
 	//todo: exit status, write to stderr, embed version and build
 	flag.Usage = func() {
 		fmt.Println("Usage: kubechange -l <label> <file> ...")
 		fmt.Printf("kubechange helps keep local and remote Kubernetes state up-to-date\n\n")
 		fmt.Println("-l string\tLabel to use as a filter")
+		fmt.Println("-n string\tNamespace of compared resources")
 		fmt.Println("-e string\tUpdate cluster objects")
 	}
 
 	label := flag.String("l", "", "Label to use as filter")
+	namespace := flag.String("n", "", "Namespace of compared resources")
 	execute := flag.Bool("e", false, "Update cluster objects")
 
 	homedir := os.Getenv("HOME")
@@ -199,7 +217,7 @@ func main() {
 		panic(err)
 	}
 
-	srcObjects := filterObjectsByLabel(localObjects, *label)
+	srcObjects := filterObjectsByLabel(filterObjectsByNamespace(localObjects, *namespace), *label)
 	//todo: consider all namespaces
 	namespaces := getObjectNamespaces(srcObjects)
 
@@ -217,7 +235,7 @@ func main() {
 		}
 	}
 
-	dstObjects := filterObjectsByLabel(remoteObjects, *label)
+	dstObjects := filterObjectsByLabel(filterObjectsByNamespace(remoteObjects, *namespace), *label)
 
 	pairs := pairObjectsByCriteria(srcObjects, dstObjects, PairCriteria{*label})
 
diff --git a/main_test.go b/main_test.go
index 49cddac..d9de057 100644
--- a/main_test.go
+++ b/main_test.go
@@ -99,6 +99,25 @@ func TestParsing(t *testing.T) {
 	}
 }
 
+func TestFiltering(t *testing.T) {
+	files := readFiles([]string{"example-test-job.yml"})
+
+	for _, file := range files {
+		objects, _ := parseManifests(file)
+		filteredByNamespace := filterObjectsByNamespace(objects, "foo")
+
+		if len(filteredByNamespace) != 0 {
+			t.Errorf("Expected no objects")
+		}
+
+		filteredByNamespace = filterObjectsByNamespace(objects, "default")
+
+		if len(filteredByNamespace) != 1 {
+			t.Errorf("Expected 1 object")
+		}
+	}
+}
+
 func TestCompare(t *testing.T) {
 	fields := compareNodeSelector(map[string]string{
 		"group": "prod",