diff --git a/crates/bevy_animation/src/lib.rs b/crates/bevy_animation/src/lib.rs index 3c2477bf64f3b..b1c2ed7c5d26d 100644 --- a/crates/bevy_animation/src/lib.rs +++ b/crates/bevy_animation/src/lib.rs @@ -453,16 +453,16 @@ fn entity_from_path( /// Verify that there are no ancestors of a given entity that have an [`AnimationPlayer`]. fn verify_no_ancestor_player( player_parent: Option<&Parent>, - parents: &Query<(Option>, Option<&Parent>)>, + parents: &Query<(Has, Option<&Parent>)>, ) -> bool { let Some(mut current) = player_parent.map(Parent::get) else { return true; }; loop { - let Ok((maybe_player, parent)) = parents.get(current) else { + let Ok((has_player, parent)) = parents.get(current) else { return true; }; - if maybe_player.is_some() { + if has_player { return false; } if let Some(parent) = parent { @@ -483,7 +483,7 @@ pub fn animation_player( names: Query<&Name>, transforms: Query<&mut Transform>, morphs: Query<&mut MorphWeights>, - parents: Query<(Option>, Option<&Parent>)>, + parents: Query<(Has, Option<&Parent>)>, mut animation_players: Query<(Entity, Option<&Parent>, &mut AnimationPlayer)>, ) { animation_players @@ -515,7 +515,7 @@ fn run_animation_player( transforms: &Query<&mut Transform>, morphs: &Query<&mut MorphWeights>, maybe_parent: Option<&Parent>, - parents: &Query<(Option>, Option<&Parent>)>, + parents: &Query<(Has, Option<&Parent>)>, children: &Query<&Children>, ) { let paused = player.paused; @@ -601,7 +601,7 @@ fn apply_animation( transforms: &Query<&mut Transform>, morphs: &Query<&mut MorphWeights>, maybe_parent: Option<&Parent>, - parents: &Query<(Option>, Option<&Parent>)>, + parents: &Query<(Has, Option<&Parent>)>, children: &Query<&Children>, ) { if let Some(animation_clip) = animations.get(&animation.animation_clip) { diff --git a/crates/bevy_pbr/src/render/mesh.rs b/crates/bevy_pbr/src/render/mesh.rs index 151bdcf31679a..6e2112d5d857a 100644 --- a/crates/bevy_pbr/src/render/mesh.rs +++ b/crates/bevy_pbr/src/render/mesh.rs @@ -256,8 +256,8 @@ pub fn extract_meshes( &GlobalTransform, Option<&PreviousGlobalTransform>, &Handle, - Option>, - Option>, + Has, + Has, Has, )>, >, @@ -278,7 +278,7 @@ pub fn extract_meshes( } let transform = transform.affine(); let previous_transform = previous_transform.map(|t| t.0).unwrap_or(transform); - let mut flags = if not_receiver.is_some() { + let mut flags = if not_receiver { MeshFlags::empty() } else { MeshFlags::SHADOW_RECEIVER @@ -298,7 +298,7 @@ pub fn extract_meshes( RenderMeshInstance { mesh_asset_id: handle.id(), transforms, - shadow_caster: not_caster.is_none(), + shadow_caster: !not_caster, material_bind_group_id: MaterialBindGroupId::default(), automatic_batching: !no_automatic_batching, },