Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"crop": false, "crop_aspect": "random" aspect ratio bucket should have sane ratio minima/maxima #1113

Open
AmericanPresidentJimmyCarter opened this issue Oct 30, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AmericanPresidentJimmyCarter

Processing bucket 74.0: 0%| probably should not happen. I don't think such an image works with the positional embeddings of most models. Consider a ratio_min and ratio_max option in the dataset configurations.

@bghira
Copy link
Owner

bghira commented Oct 30, 2024

well, if crop is false then crop_aspect=random does not apply

@AmericanPresidentJimmyCarter
Copy link
Author

OK, edited title.

@bghira
Copy link
Owner

bghira commented Nov 8, 2024

is your expectation that it functions like minimum_image_size and simply exclude the image from processing?

@bghira bghira added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 8, 2024
@AmericanPresidentJimmyCarter
Copy link
Author

Yeah, I implemented it locally like that. If you exclude it at the image processing step it's easy.

@bghira
Copy link
Owner

bghira commented Nov 8, 2024

ah, ok. initially i thought you wanted it just placed into a different min or max bucket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants