Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for java.io.Reader and java.io.Writer compatible implementations for reading and writing PGN and FEN #83

Open
seize-the-dave opened this issue Dec 20, 2021 · 0 comments

Comments

@seize-the-dave
Copy link
Contributor

Hi,

I noticed that the Board class has responsibility for loading and outputting FEN strings, and that you have a PgnHolder for reading and writing PGNs to files. I wondered if I could contribute a more java.io idiomatic way of doing this, e.g.

Iterator<Game> iter = new PgnParser(reader).iterator();
Game game = iter.next();
PgnWriter writer = new PgnWriter(appendable);
writer.write(game);

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant