Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename non-alerts within Alert namespace #149

Open
bifurcation opened this issue Dec 6, 2017 · 0 comments
Open

Rename non-alerts within Alert namespace #149

bifurcation opened this issue Dec 6, 2017 · 0 comments

Comments

@bifurcation
Copy link
Owner

Because we're using Alert more generally than the standard namespace, we've ended up with some things in the enum that aren't really alerts, like AlertNoAlert and AlertStatelessRetry. We should rename those (or add some other safeguards) to avoid accidentally sending them on the wire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant