Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pgx check for valid feature names #652

Open
mauromiguelm opened this issue Aug 29, 2023 · 2 comments
Open

Pgx check for valid feature names #652

mauromiguelm opened this issue Aug 29, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mauromiguelm
Copy link
Contributor

In dataset 76370e442 we had invalid features whcih crashed pgx.

We need to build a fast pgx check to prevent user from computing pgx when feature names (genes, proteins...) are invalid.

The valid features are listed here https://omicsplayground.readthedocs.io/en/latest/dataprep/counts.html

@ivokwee ivokwee added the bug Something isn't working label Sep 4, 2023
@ESCRI11
Copy link
Contributor

ESCRI11 commented Oct 30, 2023

@mauromiguelm Is this grep pattern OK to check for valid feature names? Could you provide some feature names examples that crash the application?

ensembl_pattern <- "^ENSG[0-9]+$"
ensembltran_pattern <- "^ENST[0-9]+$"
unigene_pattern <- "^Hs\\.[0-9]+$"
refseq_pattern <- "^NM_[0-9]+$"
accnum_pattern <- "^[A-Z][0-9]{5}$"
uniprot_pattern <- "^\\w{6}$"
symbol_pattern <- "^[A-Za-z0-9-]+$"

@mauromiguelm
Copy link
Contributor Author

this will be re-done in multi-species, if no match is found in biomart probe IDs, we have to return an error in upload module... I will keep it open as this is important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants