Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize _check_zyg method of AutoPM2BA1BS1BS2 #212

Open
gromdimon opened this issue Sep 11, 2024 · 0 comments
Open

Optimize _check_zyg method of AutoPM2BA1BS1BS2 #212

gromdimon opened this issue Sep 11, 2024 · 0 comments
Labels
enhancement New feature or request internal Internal change

Comments

@gromdimon
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Current implementation of _check_zyg method is way too complex and this is bad for maintainability.

Describe the solution you'd like
Reimplement this method by adding more helper methods and simplifying _check_zyg method itself.
Also update unit tests for this method.

Describe alternatives you've considered
N/A

Additional context
N/A
@gromdimon gromdimon added enhancement New feature or request internal Internal change labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request internal Internal change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gromdimon