Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if email is empty and provide appropriate feedback to the user #241

Open
G0dwin opened this issue Jul 24, 2017 · 0 comments
Open

Check if email is empty and provide appropriate feedback to the user #241

G0dwin opened this issue Jul 24, 2017 · 0 comments
Labels
bug Front end JavaScript

Comments

@G0dwin
Copy link
Member

G0dwin commented Jul 24, 2017

Currently, if a user is using Safari or another browser that is not compatible with form validation, the form will be submitted and an error page will be displayed:

SMTP To address may not be blank: []
  /home/rails/vendor/bundle/ruby/2.2.0/gems/mail-2.6.6/lib/mail/check_delivery_params.rb:21:in `check_to'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/mail-2.6.6/lib/mail/check_delivery_params.rb:7:in `check'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/mail-2.6.6/lib/mail/network/delivery_methods/smtp.rb:97:in `deliver!'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/mail-2.6.6/lib/mail/message.rb:2149:in `do_delivery'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/mail-2.6.6/lib/mail/message.rb:237:in `block in deliver'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionmailer-4.2.0/lib/action_mailer/base.rb:543:in `block in deliver_mail'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/notifications.rb:164:in `block in instrument'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/notifications.rb:164:in `instrument'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionmailer-4.2.0/lib/action_mailer/base.rb:541:in `deliver_mail'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/mail-2.6.6/lib/mail/message.rb:237:in `deliver'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionmailer-4.2.0/lib/action_mailer/message_delivery.rb:85:in `deliver_now'
  /home/rails/app/controllers/application_controller.rb:624:in `send_mail'
  /home/rails/app/controllers/application_controller.rb:612:in `send_confirmation'
  /home/rails/vendor/bundle/ruby/2.2.0/bundler/gems/bikecollectives_core-60b21c5a0605/app/controllers/base_controller.rb:120:in `generate_confirmation'
  /home/rails/vendor/bundle/ruby/2.2.0/bundler/gems/bikecollectives_core-60b21c5a0605/app/controllers/base_controller.rb:93:in `confirm_email'
  /home/rails/vendor/bundle/ruby/2.2.0/bundler/gems/bikecollectives_core-60b21c5a0605/app/controllers/user_controller.rb:14:in `do_confirm'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_controller/metal/implicit_render.rb:4:in `send_action'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/abstract_controller/base.rb:198:in `process_action'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_controller/metal/rendering.rb:10:in `process_action'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:117:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:117:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:234:in `block in halting'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:169:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:169:in `block in halting'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:234:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:234:in `block in halting'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:234:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:234:in `block in halting'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:169:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:169:in `block in halting'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:151:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:151:in `block in halting_and_conditional'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:92:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:92:in `_run_callbacks'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:734:in `_run_process_action_callbacks'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:81:in `run_callbacks'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/abstract_controller/callbacks.rb:19:in `process_action'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_controller/metal/rescue.rb:29:in `process_action'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_controller/metal/instrumentation.rb:31:in `block in process_action'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/notifications.rb:164:in `block in instrument'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/notifications.rb:164:in `instrument'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_controller/metal/params_wrapper.rb:250:in `process_action'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activerecord-4.2.0/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/abstract_controller/base.rb:137:in `process'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionview-4.2.0/lib/action_view/rendering.rb:30:in `process'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/rack-mini-profiler-0.10.5/lib/mini_profiler/profiling_methods.rb:76:in `block in profile_method'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_controller/metal.rb:195:in `dispatch'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_controller/metal/rack_delegation.rb:13:in `dispatch'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_controller/metal.rb:236:in `block in action'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/routing/route_set.rb:73:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/routing/route_set.rb:73:in `dispatch'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/routing/route_set.rb:42:in `serve'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/journey/router.rb:43:in `block in serve'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/journey/router.rb:30:in `each'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/journey/router.rb:30:in `serve'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/routing/route_set.rb:802:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/http_accept_language-2.1.1/lib/http_accept_language/middleware.rb:14:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/rack-1.6.8/lib/rack/etag.rb:24:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/rack-1.6.8/lib/rack/conditionalget.rb:38:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/rack-1.6.8/lib/rack/head.rb:13:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/middleware/params_parser.rb:27:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/middleware/flash.rb:260:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/rack-1.6.8/lib/rack/session/abstract/id.rb:225:in `context'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/rack-1.6.8/lib/rack/session/abstract/id.rb:220:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/middleware/cookies.rb:560:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activerecord-4.2.0/lib/active_record/query_cache.rb:36:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activerecord-4.2.0/lib/active_record/connection_adapters/abstract/connection_pool.rb:647:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:88:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:88:in `_run_callbacks'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:734:in `_run_call_callbacks'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/callbacks.rb:81:in `run_callbacks'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/middleware/callbacks.rb:27:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/middleware/remote_ip.rb:78:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/railties-4.2.0/lib/rails/rack/logger.rb:38:in `call_app'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/railties-4.2.0/lib/rails/rack/logger.rb:20:in `block in call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/tagged_logging.rb:68:in `block in tagged'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/tagged_logging.rb:26:in `tagged'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.0/lib/active_support/tagged_logging.rb:68:in `tagged'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/railties-4.2.0/lib/rails/rack/logger.rb:20:in `call'
  /home/rails/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.0/lib/action_dis…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Front end JavaScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@G0dwin