Replies: 10 comments 13 replies
-
|
I've created a separate discussion, as others might stumble across the same issues. You should be able to use the asnyc code with very little changes, basically you only need to wrap IO-bound functions using Please try if the following: # You have to import asyncio in your own code as well
import asyncio
# Could be ConnectedDriveAccount, but that will throw Deprecationwarnings
from bimmer_connected.account import MyBMWAccount
from bimmer_connected.api.regions import get_region_from_name
USERNAME = "email"
PASSWORD = "pw"
REGION = "rest_of_world"
# Corresponds to https://github.com/FilipDem/Domoticz-BMW-plugin/blob/main/plugin.py#L224
# Only creates an object with your login information, does not login yet
myBMW = MyBMWAccount(USERNAME, PASSWORD, get_region_from_name(REGION))
# MyBMW doesn't get the vehicles directly, so you'll have to call it separately.
# This can be done everytime you want to update the vehicle state (e.g. every 5 minutes or so)
# No need to login or refresh tokens, it will be done automatically.
# get_vehicles() is IO-bound and requires asyncio handling.
# If return value is a `coroutine`, use asyncio handling.
# No return value here, but asyncio.run() would return the return value of the called coroutine.
asyncio.run(myBMW.get_vehicles())
# not IO-bound, as data has been loaded
vehicle = myBMW.get_vehicle("SOME_VIN")
# IO-bound with return value
status = asyncio.run(vehicle.remote_services.trigger_remote_air_conditioning())If that doesn't solve your issues, are you able to provide a full stacktrace on where the error is occuring? |
Beta Was this translation helpful? Give feedback.
-
|
I found the solution yesterday evening. Thanks for your help! |
Beta Was this translation helpful? Give feedback.
-
|
Please keep in mind that this still a beta version and we haven't released a stable version yet, not even for our own component in Home Assistant. |
Beta Was this translation helpful? Give feedback.
-
|
I know. No worry... |
Beta Was this translation helpful? Give feedback.
-
|
Hi again, |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, didn't see the notification until yet. For the However, to me it looks as if the issue only occurs when In this case, wouldn't it make sense to keep it available? That would also mean much less login traffic, as the token is valid for 1 hour. |
Beta Was this translation helpful? Give feedback.
-
|
Problem in general is that a plugin for Domoticz is running in a Thread (managed by Domoticz --> I cannot change this). And it is possible to stop or restart a plugin... That's why I am putting it on None when stopping the plugin or when something goes wrong with the "get_vehicles()". |
Beta Was this translation helpful? Give feedback.
-
|
I have just released a new version (0.9.0b2) that should at least fix the The async pattern should work with threads, provided there is only one thread available for bimmer_connected (i.e. it should be fine if there is one thread that starts and then stops/clears Supporting both async and sync interfaces proably will lead to a duplication of code, but I am not totally sure about that. That would need further investigation. |
Beta Was this translation helpful? Give feedback.
-
|
Hi, at least this problem is indeed solved. Now I still have frequent crashes in the plugin, however I haven't yet identified whether the problem is in Domoticz itself or cause by the threading combined with asyncio. |
Beta Was this translation helpful? Give feedback.
-
|
👍 Is the code in your github the most current version? I could have another look at it. |
Beta Was this translation helpful? Give feedback.
-
|
The problem with the crash it solved. It was a problem in domoticz. When restarting Domoticz, all goes well... However when restarting just the plugin (equivalent of the The code: plugin.py.txt
These run in a thread Whatever it means for you, you can find the logging below: |
Beta Was this translation helpful? Give feedback.
-
|
I'm with you, looks as it should be working... Can you try the following to get a better error message?
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the hint... I add also the status that I got from 2022-03-06 19:34:22.368 Status: TestBmw: Stop directive received. 2022-03-06 19:34:23.037 TestBmw: Got 13 devices: 2022-03-06 19:34:25.329 TestBmw: Login error: 'NoneType' object is not callable 2022-03-06 19:35:22.062 TestBmw: Handling task: Login. |
Beta Was this translation helpful? Give feedback.
-
|
I have no idea why this is happening. The error message The only thing that strikes me very odd is the importing of default python libraries. import sys, os
major,minor,x,y,z = sys.version_info
sys.path.append('/usr/lib/python3/dist-packages')
sys.path.append('/usr/local/lib/python{}.{}/dist-packages'.format(major, minor))
sys.path.append(os.path.dirname(os.path.dirname(os.path.realpath(__file__))))I think this is not needed (the correct base paths should be leveraged automatically) and is also not used in BaseTemplate.py. It could be that this somehow messes up imports, especially when the thread is started and stopped. |
Beta Was this translation helpful? Give feedback.
-
|
I understand the concern, however I tested and it doesn't make any difference. |
Beta Was this translation helpful? Give feedback.
-
|
Ah, this is a very interesting catch and of course explain why we were not able to explain that otherwise... :) I'll have a look how to best integrate this! |
Beta Was this translation helpful? Give feedback.
-
|
Ok, I would try it in different ways. Would you be able to test those before I include one? They are in my order of preference to keep the code understandable. Option 1 (testing if strptime is def parse_datetime(date_str: str) -> Optional[datetime.datetime]:
"""Convert a time string into datetime."""
if not date_str:
return None
date_formats = ["%Y-%m-%dT%H:%M:%S.%f%z", "%Y-%m-%dT%H:%M:%S%z", "%Y-%m-%dT%H:%M:%S.%fZ", "%Y-%m-%dT%H:%M:%SZ"]
for date_format in date_formats:
try:
if datetime.datetime.strptime is None:
datetime = None
import datetime
parsed = datetime.datetime.strptime(date_str, date_format)
# Assume implicit UTC for Python 3.6
if sys.version_info < (3, 7):
parsed = parsed.replace(tzinfo=datetime.timezone.utc)
return parsed
except ValueError:
pass
_LOGGER.error("unable to parse '%s' using %s", date_str, date_formats)
return NoneOption 2: def parse_datetime(date_str: str) -> Optional[datetime.datetime]:
"""Convert a time string into datetime."""
if not date_str:
return None
date_formats = ["%Y-%m-%dT%H:%M:%S.%f%z", "%Y-%m-%dT%H:%M:%S%z", "%Y-%m-%dT%H:%M:%S.%fZ", "%Y-%m-%dT%H:%M:%SZ"]
for date_format in date_formats:
try:
try:
parsed = datetime.datetime.strptime(date_str, date_format)
except TypeError:
datetime = None
import datetime
parsed = datetime.datetime.strptime(date_str, date_format)
# Assume implicit UTC for Python 3.6
if sys.version_info < (3, 7):
parsed = parsed.replace(tzinfo=datetime.timezone.utc)
return parsed
except ValueError:
pass
_LOGGER.error("unable to parse '%s' using %s", date_str, date_formats)
return NoneOption 3: def parse_datetime(date_str: str) -> Optional[datetime.datetime]:
"""Convert a time string into datetime."""
if not date_str:
return None
date_formats = ["%Y-%m-%dT%H:%M:%S.%f%z", "%Y-%m-%dT%H:%M:%S%z", "%Y-%m-%dT%H:%M:%S.%fZ", "%Y-%m-%dT%H:%M:%SZ"]
for date_format in date_formats:
try:
try:
parsed = datetime.datetime.strptime(date_str, date_format)
except TypeError:
import time
parsed = datetime.datetime.fromtimestamp(time.mktime(time.strptime(date_str, date_format)))
# Assume implicit UTC for Python 3.6
if sys.version_info < (3, 7):
parsed = parsed.replace(tzinfo=datetime.timezone.utc)
return parsed
except ValueError:
pass
_LOGGER.error("unable to parse '%s' using %s", date_str, date_formats)
return None |
Beta Was this translation helpful? Give feedback.
-
|
Unfortunately, option 1 & 2 give similar problems: "UnboundLocalError: local variable 'datetime' referenced before assignment" Option1: Option2 |
Beta Was this translation helpful? Give feedback.
-
|
OK, one last try please 🙂 For options 1/2: if datetime is None:
datetime = None # this could probalby be skipped as well
import datetimeIf both don't work, I'll probably change the whole datetime parsing to the one based on |
Beta Was this translation helpful? Give feedback.
-
|
Still the same... I got always Just a hint from https://docs.python.org/2/library/datetime.html#datetime.datetime.strptime F |
Beta Was this translation helpful? Give feedback.
-
|
Hi Filip, sorry for being quiet so long... I just pushed 0.9.0.0b6 which should include the |
Beta Was this translation helpful? Give feedback.
-
|
Thank you... I am on holiday and will take it up when I am back. |
Beta Was this translation helpful? Give feedback.
-
|
Top! Seems OK now. I updated by Domoticz plugin and use the beta version now... I will let it run for a while now. But first impression is OK! |
Beta Was this translation helpful? Give feedback.
-
Hi,
I just tried to update my Domoticz plugin with the breaking changes. I am using threading mechanism inside Domoticz as recommended for the Domoticz plugin development.
However when calling the
MyBMWAccount(USERNAME, PASSWORD, Regions.REST_OF_WORLD)inside the thread, I receive the errorThere is no current event loop inside the thread. I suppose it has something to do with the asyncio...Any hint how to get this solved?
See https://github.com/FilipDem/Domoticz-BMW-plugin/blob/main/plugin.py, function
handleTasks(line 210).Thanks,
F
Originally posted by @FilipDem in #420 (comment)
Beta Was this translation helpful? Give feedback.
All reactions