Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the loglevels used #10

Open
hejung opened this issue Jun 22, 2023 · 0 comments
Open

Review the loglevels used #10

hejung opened this issue Jun 22, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@hejung
Copy link
Collaborator

hejung commented Jun 22, 2023

Some loglevels used feel a bit too noisy, e.g. it is probably not needed to log an info message every time we submit a slurm job as we can be submitting quite a lot of jobs when using asyncmd to its full potential.

While doing this doing this one should also make sure that all logging calls use the best practice calling convention, i.e. no f-strings, no + to concatenate, and fill in all variables via the arguments to the logging call.

This should be a good first issue, because it entails reading the code and thinking about it, but all changes only affect logging behavior so you can not really break anything. Since all changes are local it also nicely splits into doing it for one submodule/file at a time.

@hejung hejung added the good first issue Good for newcomers label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant