You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are cases when materials in a SourcePlate require different SPtype values when transfering via the echo. For example, mammalian lysate require "384PP_AQ_GP" while water, DNA etc. requires "384PP_Plus_AQ_BP".
Potential solution
If there isn't an established solution to this problem, I'd recommend adding an optional argument to EchoRun.write_picklist method where the user can override plate.type for a given EchoSourceMaterial.name attribute. Something like passing in a iterable of tuples which override plate.type for the associated material e.g.
[("txtl_mm", "384_Plus_AQ_GP")]
Would mean all rows where txtl_mm is transfered, use the associated 384_Plus_AQ_GP plate type and everything else is transfered with the default. Let me know if this is works and I'd be happy to make the changes and write associated tests.
The text was updated successfully, but these errors were encountered:
@hainesm6 I'm not sure that @sclamons and/or @WilliamIX are actively maintaining this package or not, so I'll respond (always dangerous -:).
Your solution sounds fine, though you might want to use a dict instead of a tuple and use a regex for the name, with the idea that the first matching entry gets used. So if you set plate.type to '384_Plus_AQ_GP' then it uses that for the entire plate, but if you set it to {r'txtl_mm*': '384_Plus_AQ_GP', r'*': 'default'} then you get '384_Plus_AQ_GP' for anything that is txtl_mm* and 'default' for everything else.
Thanks @murrayrm! Yes agreed, a dict would improve readability and regex seems sensible in case there are multiple materials where an overide is required.
Problem
There are cases when materials in a
SourcePlate
require differentSPtype
values when transfering via the echo. For example, mammalian lysate require"384PP_AQ_GP"
while water, DNA etc. requires"384PP_Plus_AQ_BP"
.Potential solution
If there isn't an established solution to this problem, I'd recommend adding an optional argument to
EchoRun.write_picklist
method where the user can overrideplate.type
for a givenEchoSourceMaterial.name
attribute. Something like passing in a iterable of tuples which overrideplate.type
for the associated material e.g.Would mean all rows where txtl_mm is transfered, use the associated 384_Plus_AQ_GP plate type and everything else is transfered with the default. Let me know if this is works and I'd be happy to make the changes and write associated tests.
The text was updated successfully, but these errors were encountered: