Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumsum in Moving transform weird error: wrong results for 1st, 2nd, 4th and 5th column selected #265

Open
wvdvegte opened this issue Dec 12, 2023 · 2 comments
Assignees

Comments

@wvdvegte
Copy link

Timeseries version

0.6.1

Orange version

3.36.3

Expected behavior

When applying Moving Transform to compute cumulative sums for one or more columns, the cumulative sum up till each row is computed correctly

Actual behavior

The cumulative sum is computed correctly for third column for which cumsum was checked, and also for the 6th, 7th, 8th and so on. For the 1st, 2nd, 4th and 5th column, incorrect results are provided.

Steps to reproduce the behavior

See attached workflow

Additional info (worksheets, data, screenshots, ...)

moving transform bug.ows.zip

@janezd janezd assigned janezd and ajdapretnar and unassigned janezd Dec 22, 2023
@ajdapretnar
Copy link
Collaborator

This works as expected. Your output is "Keep original data", where on hover reveal the original data is kept, except for the N-1 (where N is window width). If you select "Include leading instances", you will see the aggregation is correct.

Let me know if the issue was solved.

@wvdvegte
Copy link
Author

Thanks, @ajdapretnar - I see now how it is supposed to work. But "Keep original data" is misleading because the leading instances aren't kept (which are also "original data"). Suggestion: name the options "discard original data", "keep original data without leading instances" and "keep all original data" (or "keep original data with leading instances"). I would also reverse order in which the options are listed - the discard option seems less useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants