Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate master branch to main #355

Open
Zeitsperre opened this issue May 6, 2024 · 1 comment
Open

Migrate master branch to main #355

Zeitsperre opened this issue May 6, 2024 · 1 comment

Comments

@Zeitsperre
Copy link
Collaborator

This is something we have been progressively doing across all the Ouranosinc code repositories. I don't imagine it would be too controversial/breaking to perform that here as well.

@tlvu how much of a disruption would such a change be here?

@tlvu
Copy link
Collaborator

tlvu commented May 6, 2024

You'll have to ensure notebook autodeployment still works, this line to change https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/blob/81987bf3fbcdfc057f63a11af15738e1ba587e7b/default_build_params#L32

And Jenkins will test the new branch name: https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/blob/81987bf3fbcdfc057f63a11af15738e1ba587e7b/Jenkinsfile#L62

Same process if you want to change pavics-sdi, PAVICS-landing, Raven, RavenPy repos. Together with Finch, those are the 5 repos we autodeploy notebooks to PAVICS and we run Jenkins nightly test on them.

The tricky part is the rename in the 5 repos and the merge in the PAVICS-e2e-workflow-tests repo have to be done in sync, at the same time.

That said, if we have users that bookmarked the various tutorials notebooks and their old links contain master, they will break. But leaving the old master name behind, they will get old stale version without knowing about it. Same problem if our users have existing clone/checkout of the 5 repos.

So I wonder if we have a mean to notify our users to soften the blow of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants