CODEBASE: Validate AllGangs and StockMarket after loading with JSON.parse

[catloversg]

Ideally, when we validate loaded data from JSON.parse, we should validate the actual data (checking the data with JSON schemas), not just the "shape" of it (using instanceOf, checking if it's an object with typeof, etc.). Doing that for all json-able classes requires a tremendous effort while the benefit is too small (invalid data indicates buggy saving/loading code or badly edited save file). That's the reason why we have not validated the actual data until now. Originally, I only planned to validate theme data, because it can be set directly by the player via UI. In #1775, I see that AllGangs and StockMarket can also be validated this way, so I made 4 exceptions for that PR:

• AllGangs.
• StockMarket.
• Theme.
• Editor theme.

This PR handles AllGangs and StockMarket.

Test:
AllGangs:
AllGangs's structure has not been changed since at least 9137c24 (v0.43.1). I tested with a save file from v1.0.0.

StockMarket:
StockMarket's structure has not been changed since 1b41e33 (this commit was included in v1.3.0). I tested with a save file from v1.3.0.

Webpack Bundle Analyzer:

[d0sboots]

Very exciting! I wasn't expecting you (or anyone) to take this on, which we'll need to be really careful with because it has lots of implications for old saves.

[catloversg]

AllGangs

enum and required use GangConstants.Names instead of a hardcoded array. Currently, gang code cannot handle invalid data:

• Missing gangs: Gang UI crashes. Errors in processTerritoryAndPowerGains and Achievements.ts (GANG_TERRITORY).
• Have unknown gangs: Errors in processTerritoryAndPowerGains.

If we add or move gangs in the future, we have to refactor our code to deal with missing gangs and unknown gangs. Loading a newer save file with a different gang list in our current code results in bugs.

StockMarket

I removed many requirements as you requested. Tested:

• Load a valid save file from v1.3.0.
• Add a new stock (ECorp1 with symbol ECP1). Load the game with the save file containing the new (unknown) stock.

[d0sboots]

Great! Aside from the minor business with comments, this is just waiting on me testing it against old saves.