You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The install_plugins() function in install_plugins.py is failing pylint check on:
scripts/plugins/install_plugins.py:17:0: R0914: Too many local variables (22/15) (too-many-locals)
scripts/plugins/install_plugins.py:17:0: R0915: Too many statements (59/50) (too-many-statements)
The function has almost 200 lines and pylint with multiple warnings is a great indicator that it needs to be restructured and divided into smaller logical pieces. For instance:
Extract it into a new Plugin class perhaps with another layer PluginInstaller (note: PluginDeployerRefactor deploy_plugins() in deploy_plugins.py #328) with multiple methods, so the interface would be Plugin.install() that we can call while iterating over each plugin in the sequence.
Then another class PluginConfig would handle plugin config parsing and processing.
The pylint check for this function is silenced for now, don't forget to unsilence it when the refactoring is done.
The text was updated successfully, but these errors were encountered:
Silence for now, refactor this function in the future.
> R0914: Too many local variables (22/15) (too-many-locals)
> R0915: Too many statements (59/50) (too-many-statements)
See: #329
This is an unfinished refactoring sub-task coming from the Add Pylint as a python static code analyzer #298.
The
install_plugins()
function ininstall_plugins.py
is failing pylint check on:The function has almost 200 lines and pylint with multiple warnings is a great indicator that it needs to be restructured and divided into smaller logical pieces. For instance:
Plugin
class perhaps with another layerPluginInstaller
(note:PluginDeployer
Refactor deploy_plugins() in deploy_plugins.py #328) with multiple methods, so the interface would bePlugin.install()
that we can call while iterating over each plugin in the sequence.PluginConfig
would handle plugin config parsing and processing.The pylint check for this function is silenced for now, don't forget to unsilence it when the refactoring is done.
The text was updated successfully, but these errors were encountered: