Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsupported watermark functionality #28

Open
bbabic opened this issue Aug 23, 2013 · 0 comments
Open

unsupported watermark functionality #28

bbabic opened this issue Aug 23, 2013 · 0 comments

Comments

@bbabic
Copy link

bbabic commented Aug 23, 2013

Current ZencoderWatermark class does not support width & height properties expressed in percentages (Zencoder API allows for % input).

Suggested solution:
a) change int type to String type and thus allow input like "100%"
b) add extra boolean flag to mark value as percent expression. This can be done either as extra getter/setter methods for width and height properties (e.g. setWidthInPercent(123)) or as standalone method (e.g. setIsWidthInPercent(true))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant