Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type in jsdoc #438

Open
huven opened this issue Jan 6, 2025 · 0 comments
Open

Incorrect type in jsdoc #438

huven opened this issue Jan 6, 2025 · 0 comments
Labels

Comments

@huven
Copy link

huven commented Jan 6, 2025

Issue #408 is still present in the latest version.

I think the cause is that Attachments.upload has jsdoc that requires the file to be presented as Buffer, which is then passed to Transporter.upload which expects a Stream.

Successfully tested that calling Attachments.requestUpload (bypassing .upload as it has incorrect prototype) with a Stream works.

Change the jsdoc to require Stream instead of Buffer? Or add Buffer support to Transporter.upload?

@huven huven added the bug label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant