Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the product version in ecmwf.py template file after Beta phase #39

Closed
blaylockbk opened this issue Jan 27, 2022 · 3 comments · Fixed by #224
Closed

Update the product version in ecmwf.py template file after Beta phase #39

blaylockbk opened this issue Jan 27, 2022 · 3 comments · Fixed by #224
Labels
ECMWF Issues with access to ECMWF open data files
Milestone
Next Release

Comments

@blaylockbk
Copy link
Owner

As soon as the beta phase is over, I will need to change this value in the ecmwf.py template file

Herbie/herbie/models/ecmwf.py

Lines 15 to 17 in 3b70ab6

# TODO: This will need to be updated someday
version = '0p4-beta'
#version = '0p4'

@blaylockbk blaylockbk added the ECMWF Issues with access to ECMWF open data files label Jan 27, 2022
@blaylockbk blaylockbk changed the title Update the product version after Beta phase Update the product version in ecmwf.py template file after Beta phase Jan 27, 2022
@blaylockbk
Copy link
Owner Author

Does this tweet mean that we should expect to see ECMWF open data on AWS, too?

https://twitter.com/ECMWF/status/1601225879916449793

If that is true, Herbie needs to add AWS as a source for these forecasts.

@blaylockbk
Copy link
Owner Author

Update the SOURCES in the model template file ecmwf.py

Details here:
https://confluence.ecmwf.int/display/DAC/ECMWF+open+data%3A+real-time+forecasts

@blaylockbk blaylockbk added this to the Next Release milestone Aug 9, 2023
@blaylockbk blaylockbk linked a pull request Aug 12, 2023 that will close this issue
Added fallback to ecmwf to also look in short cutoff #224
Merged
@blaylockbk blaylockbk reopened this Aug 12, 2023
@blaylockbk
Copy link
Owner Author

No longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ECMWF Issues with access to ECMWF open data files
Projects
None yet
Milestone
Next Release
Development

Successfully merging a pull request may close this issue.

Added fallback to ecmwf to also look in short cutoff blaylockbk/Herbie
1 participant
@blaylockbk