feat: allow plugins to set custom patterns for dangerous commands #281
+62
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the
is_dangerous_command
utility function to move it to a separate module, then adds a method to that module which allows adding custom patterns. Our use case is that we have some internal CLI tooling touching production resourcing that is definitely dangerous, so we'd like to be able to add an invocation to our plugin to flag those commands as requiring human approval.Testing
.*
entry from the__init__.py
of our custom plugin and seeing a command blocked: