Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly calculate eofcreate address #1619

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: correctly calculate eofcreate address #1619

merged 1 commit into from
Jul 16, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Jul 16, 2024

#1600 introduced small changes to nonce handling during eofcreate which resulted in incremented nonce being used for address calculation when TxEnv does not include nonce.

rakita
rakita approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! I am in the process of integrating EOF statetest so this shouldn't happen in future.

@rakita rakita merged commit 23b5c88 into bluealloy:main Jul 16, 2024
26 checks passed
This was referenced Jul 15, 2024
Closed
Merged
j75689 pushed a commit to j75689/revm that referenced this pull request Aug 1, 2024
@klkvr @j75689
fix: correctly calculate eofcreate address (bluealloy#1619)
5d37d43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klkvr @rakita @mattsse @DaniPopes