Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing resources management #92

Open
Azbesciak opened this issue Jun 30, 2020 · 1 comment
Open

Missing resources management #92

Azbesciak opened this issue Jun 30, 2020 · 1 comment

Comments

@Azbesciak
Copy link
Contributor

Hi, I noticed (because of the problems I have) that listeners on draw events are not released with ngOnDestroy. The question is - why? Is it because of performance reasons or does it seem to be unnecessary?

My scenario is that I have a single draw control for multiple groups of layers, one group active to edit/add at the time. I need to swich between them, and I came to an idea to reuse the single control (multiple events emitted, for each - I think it is better to have a single place where it is managed).
But the problem is with those events, all the time new one is added, whereas the directive is still the same.

@reblace
Copy link
Contributor

reblace commented Aug 3, 2020

I can try to fix this in a minor release. I agree we should be cleaning those up on destroy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants