-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some tests fail on 3.12 - and should be failing on older versions #520
Comments
dperl-dls
changed the title
Some tests fail on 3.12
Some tests fail on 3.12 - and should be failing on older versions
Aug 14, 2024
similarly
|
Indeed I believe those should be awaited. It's interesting that that would not have been caught in tests before |
Great. I've fixed these in my python 3.12 branch https://github.com/bluesky/ophyd-async/tree/update_p4p_and_py312 but am waiting on another release of p4p built against numpy 2 for python versions 3.11 and 10 before it can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In testing the new p4p release I came across some test failures which I think are wrong, in particular
tests/core/test_mock_signal_backend.py::test_blocks_during_put
In lines 186 and 187 I believe this should test for
"first_value"
as the signal shouldn't have changed yet with puts blocked - this works correctly on python 3.12 but not earlier versions.The text was updated successfully, but these errors were encountered: