Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastCS Eiger: Put system tests in CI #531

Open
DominicOram opened this issue Aug 19, 2024 · 1 comment
Open

FastCS Eiger: Put system tests in CI #531

DominicOram opened this issue Aug 19, 2024 · 1 comment

Comments

@DominicOram
Copy link
Contributor

#528 introduced some system tests that could be run by manually. We should put these in CI so that we properly catch errors with them. The tests themselves involve a number of different containers running IOCs and the simulator. There are examples of orchestrating containers like this in GH Actions at https://github.com/DiamondLightSource/authz/blob/main/.github/workflows/bundler-code.yml and https://github.com/DiamondLightSource/workflows/blob/main/.github/workflows/kyverno-policy.yaml.

Acceptance Criteria

  • When code is pushed to GH the Eiger system tests get run
  • These tests are a pre-requisite to merging PRs
  • These tests are passing
@DominicOram DominicOram mentioned this issue Aug 19, 2024
Merged
@DominicOram
Copy link
Contributor Author

One potential issue that we would need to work around is that the simulator container does not currently like running headless as it uses zellij

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DominicOram